Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: avoid recalculating custom emoji index #446

Merged
merged 1 commit into from
Sep 7, 2024
Merged

perf: avoid recalculating custom emoji index #446

merged 1 commit into from
Sep 7, 2024

Conversation

nolanlawson
Copy link
Owner

This won't show up in the benchmarks, but we do an extra recalculation of the custom emoji search index that we don't need to.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +4% (-0.92ms - +1.53ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -7% - +3% (-8.48ms - +3.67ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -4% - +5% (-2.37ms - +2.85ms)
    this-change vs tip-of-tree
  • emoji-picker-element-search: unsure 🔍 -9% - +1% (-4.18ms - +0.70ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -4% - +3% (-1.69ms - +1.38ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.60ms - 35.42ms-unsure 🔍
-3% - +4%
-0.92ms - +1.53ms
tip-of-tree
tip-of-tree		33.39ms - 35.03msunsure 🔍
-4% - +3%
-1.53ms - +0.92ms		-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
107.42ms - 115.55ms-unsure 🔍
-7% - +3%
-8.48ms - +3.67ms
tip-of-tree
tip-of-tree		109.37ms - 118.41msunsure 🔍
-3% - +8%
-3.67ms - +8.48ms		-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.32ms - 54.98ms-unsure 🔍
-4% - +5%
-2.37ms - +2.85ms
tip-of-tree
tip-of-tree		51.05ms - 54.77msunsure 🔍
-5% - +4%
-2.85ms - +2.37ms		-
emoji-picker-element-search
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
43.05ms - 46.51ms-unsure 🔍
-9% - +1%
-4.18ms - +0.70ms
tip-of-tree
tip-of-tree		44.80ms - 48.25msunsure 🔍
-2% - +9%
-0.70ms - +4.18ms		-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.84ms - 44.89ms-unsure 🔍
-4% - +3%
-1.69ms - +1.38ms
tip-of-tree
tip-of-tree		42.88ms - 45.16msunsure 🔍
-3% - +4%
-1.38ms - +1.69ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

Size Change: +38 B (+0.1%)

Total Size: 36.4 kB

Filename Size Change
./bundle.js 36.4 kB +38 B (+0.1%)

compressed-size-action

@nolanlawson nolanlawson merged commit 0c09f56 into master Sep 7, 2024
3 checks passed
@nolanlawson nolanlawson mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nolanlawson